Skip to content

Fix erroneous nil error return in FindOne. #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

matthewdale
Copy link
Collaborator

Summary

  • Return a SingleResult with an error if building options fails in FindOne.

Background & Motivation

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the priority-3-low Low Priority PR for Review label Jan 30, 2025
Copy link
Contributor

API Change Report

No changes found!

Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matthewdale matthewdale merged commit 8eb83cb into mongodb:master Jan 30, 2025
26 of 35 checks passed
@matthewdale
Copy link
Collaborator Author

drivers-pr-bot please backport to release/2.0

mongodb-drivers-pr-bot bot pushed a commit that referenced this pull request Feb 19, 2025
matthewdale added a commit that referenced this pull request Feb 19, 2025
alcaeus added a commit that referenced this pull request Mar 4, 2025
* release/2.0:
  BUMP v2.0.1
  GODRIVER-3477 Bump golang.org/x/crypto from 0.29.0 to 0.31.0 [release/2.0] (#1952)
  GODRIVER-3284 Allow valid SRV hostnames with less than 3 parts. (#1898) [release/2.0] (#1949)
  GODRIVER-3452 MergeClientOptions returns object when given nil arguments (#1917) [release/2.0] (#1948)
  GODRIVER-3443 Remove internal APIs in migration guide. (#1911) [release/2.0] (#1951)
  GODRIVER-3470 Correct BSON unmarshaling logic for null values (#1924) [master] (#1945) [release/2.0] (#1947)
  Fix erroneous nil error return in FindOne. (#1926) [release/2.0] (#1944)
  GODRIVER-3298 Handle joined errors correctly in WithTransaction. (#1928) [release/2.0] (#1931)
  GODRIVER-3307 clone returned byte slice in MarshalValue (#1913) [release/2.0] (#1921)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low Low Priority PR for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants