-
Notifications
You must be signed in to change notification settings - Fork 905
GODRIVER-3149: OIDC Spec Cleanup #1757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
${DRIVERS_TOOLS}/.evergreen/auth_oidc/setup.sh | ||
env: | ||
MONGODB_VERSION: "8.0" | ||
args: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that human18 fails if we don't run with MONGODB_VERSION 8.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is tracked by https://jira.mongodb.org/browse/PYTHON-4447, which I updated to reflect today's status.
API Change ReportNo changes found! |
@@ -38,7 +39,7 @@ func tokenFile(user string) string { | |||
return path.Join(oidcTokenDir, user) | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter doesn't catch misspelled function names, hah!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
GODRIVER-3149
Summary
This cleans up a few things that changed in the spec during implementation and adds the 3 tests that were missing from previous tickets
Background & Motivation
OIDC epic