Skip to content

GODRIVER-3149: OIDC Spec Cleanup #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Conversation

pmeredit
Copy link
Collaborator

GODRIVER-3149

Summary

This cleans up a few things that changed in the spec during implementation and adds the 3 tests that were missing from previous tickets

Background & Motivation

OIDC epic

@pmeredit pmeredit requested a review from matthewdale August 14, 2024 20:47
${DRIVERS_TOOLS}/.evergreen/auth_oidc/setup.sh
env:
MONGODB_VERSION: "8.0"
args:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that human18 fails if we don't run with MONGODB_VERSION 8.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is tracked by https://jira.mongodb.org/browse/PYTHON-4447, which I updated to reflect today's status.

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the priority-3-low Low Priority PR for Review label Aug 14, 2024
Copy link
Contributor

API Change Report

No changes found!

@@ -38,7 +39,7 @@ func tokenFile(user string) string {
return path.Join(oidcTokenDir, user)
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter doesn't catch misspelled function names, hah!

Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@blink1073 blink1073 merged commit 5cb35dd into mongodb:v1 Aug 26, 2024
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low Low Priority PR for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants