Skip to content

GODRIVER-3277 Rename DropWithKey to DropOneWithKey #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

timothy-kim-mongo
Copy link
Contributor

@timothy-kim-mongo timothy-kim-mongo commented Jul 22, 2024

GODRIVER-3277

Summary

The solution for GODRIVER-2701 adds a new method to the IndexView API called DropWithKey. The standard API for dropOne overloads the function signature to include a key option.

This PR renames DropWithKey to DropOneWithKey before releasing 1.17 to follow the spec as best as possible.

@timothy-kim-mongo timothy-kim-mongo merged commit 570ae17 into mongodb:v1 Jul 22, 2024
23 of 24 checks passed
@timothy-kim-mongo timothy-kim-mongo deleted the GODRIVER-3277 branch July 22, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants