GODRIVER-2728: Implement automatic Azure token acquisition callback #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not go live, I'm sure
…r OIDC that is probably, maybe, possibly correct
… need to get down to Handshake instead of creating the Authenticator in Handshake as we do now
…o I'm sure it's right
API Change ReportNo changes found! |
|
@qingyang-hu sorry about the bot request, I was waiting for static analysis before adding reviewers |
pmeredit
commented
Jul 15, 2024
| @@ -1975,6 +1975,31 @@ tasks: | |||
| commands: | |||
| - func: "run-oidc-auth-test-with-test-credentials" | |||
|
|
|||
| - name: "oidc-auth-test-azure-latest" | |||
There was a problem hiding this comment.
the test is compiled ahead of time and just the compiled exe is ran on the azure vm. This matters more for gcp vm which is far slower, but it's good to be consistent
pmeredit
commented
Jul 15, 2024
matthewdale
requested changes
Jul 20, 2024
x/mongo/driver/auth/oidc.go
Outdated
Comment on lines
212
to
215
| var azureResp struct { | ||
| AccessToken string `json:"access_token"` | ||
| ExpiresOn string `json:"expires_on"` | ||
| } |
There was a problem hiding this comment.
Optional: You can skip the separate integer parsing step by using the ,string struct tag option for ExpiresOn.
E.g.
var azureResp struct {
AccessToken string `json:"access_token"`
ExpiresOn int64 `json:"expires_on,string"`
}
Co-authored-by: Matt Dale <[email protected]>
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Aug 1, 2024
…ongodb#1703) Co-authored-by: Matt Dale <[email protected]> (cherry picked from commit 9a02911)
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement automatic Azure token acquisition callback
Background & Motivation
required by OIDC epic