-
Notifications
You must be signed in to change notification settings - Fork 905
GODRIVER-3108 Optimize writeServerSelector #1509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change ReportNo changes found! |
prestonvasquez
requested changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @isopov , thanks for the contribution. In addition to the suggested changes, could you add the following benchmark to mongo/description/selector_test.go:
func Benchmark_SelectServer_SelectServer(b *testing.B) {
topology := Topology{Kind: ReplicaSet} // You can change the topology as needed
candidates := []Server{
{Kind: Mongos},
{Kind: RSPrimary},
{Kind: Standalone},
}
selector := writeServerSelector{} // Assuming this is the receiver type
b.ReportAllocs()
b.ResetTimer()
for i := 0; i < b.N; i++ {
_, err := selector.SelectServer(topology, candidates)
if err != nil {
b.Fatalf("Error selecting server: %v", err)
}
}
}
Co-authored-by: Preston Vasquez <[email protected]>
prestonvasquez
approved these changes
Jan 26, 2024
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Jan 26, 2024
Co-authored-by: Preston Vasquez <[email protected]> (cherry picked from commit 1fd1bc2)
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimize allocations of Server slices during writes.
Background & Motivation
On one of my services this function allocates 295 GBs over several days.

This is very similar to #1107 #1108 #1111. NB: one of these optimizations was reverted for correctness - 26e6c8a I used similar here, but cannot judge wether it may be used here.