DRIVERS-2945 AWS EKS Pod Identity #655
Conversation
| ["bash", HERE / "lib" / "eks-pod-teardown.sh", name], cwd=HERE / "lib" | ||
| ) | ||
|
|
||
| return dict() |
There was a problem hiding this comment.
What's the purpose of this return value?
There was a problem hiding this comment.
It has to be a dict, with the values that will get exposed in test-env.sh. In this case no variables are needed.
| EKS_DIR="../../k8s/eks" | ||
|
|
||
| cat <<EOF >> $EKS_DIR/secrets-export.sh | ||
| export EKS_CLUSTER_NAME=$EKS_CLUSTER_NAME |
There was a problem hiding this comment.
Should the required setting of these variables be documented in the README?
There was a problem hiding this comment.
Oh, no, this is set automatically by aws_setup.py. The only thing we need is PROJECT_DIRECTORY, which is covered already.
| @@ -8,8 +8,8 @@ set -eu | |||
| SCRIPT_DIR=$(dirname ${BASH_SOURCE[0]}) | |||
| . $SCRIPT_DIR/handle-paths.sh | |||
|
|
|||
| NAME=$1 | |||
| if [ -z "$NAME" ]; then | |||
| _NAME=$1 | |||
There was a problem hiding this comment.
Are these name changes necessary for this PR, or can they be moved into a separate cleanup PR?
There was a problem hiding this comment.
They were needed, since $NAME was overriding the parent environment.
Co-authored-by: Noah Stapp <[email protected]>
No description provided.