fix(hadron-build, compass): restore Isolated and Readonly special behavior in packaged application COMPASS-8129 #6147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
force-pushed
the
compass-8129-fix-hadron-distribution
branch
from
0ee5301 to
3c3b9cd
Compare
gribnoysup
commented
Aug 21, 2024
| exports.builder = { | ||
| nodejs_version: { | ||
| describe: 'What version of node.js is required for this app?', | ||
| default: '^7.4.0' |
There was a problem hiding this comment.
Drive-by, just caught my eye how out of date this was, so I removed this script too
| @@ -405,7 +406,7 @@ functions: | |||
| <<: *compass-env | |||
| DEBUG: ${debug} | |||
| npm_config_loglevel: ${npm_loglevel} | |||
| COMPASS_DISTRIBUTION: ${compass_distribution} | |||
| HADRON_DISTRIBUTION: ${compass_distribution} | |||
There was a problem hiding this comment.
Changed it back to HADRON_ because otherwise it's hard to search through the code for all occurences, I'm totally up for changing this to COMPASS_ at some point, but we should probably do this for all the mentions of hadron
…connections, gen-vuln-check tasks
lerouxb
approved these changes
Aug 21, 2024
himanshusinghs
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we separated Compass compilation process from the app packaging, we stopped passing correct environment to the compile script, which lead to webpack config not setting environment correctly when bundling the assets. This turned both Compass isolated and readonly into "normal" editions even though the installer and the binary were still branded correctly.
This patch fixes the issue by being more explicit in where and how we set the expected env variable, I also modified the
Targetclass, the main source of this information right now, that is used during build and compilation to not have an unsafe default anymore and throw ifHADRON_DISTRIBUTIONvariable was not provided, this should ensure we don't accidentally break it anymore