-
Notifications
You must be signed in to change notification settings - Fork 80
Conversation
Hmm, I'm not familiar with CI at all, but now this PR seems to break tests:
I have
|
tests/test_address.py
Outdated
class Tests(object): | ||
__test__ = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so pytest
will run all test_*
methods assuming they are, well, tests.
This is of course a problem for test classes mixins. But then again, you are right in worrying about it as I clearly forgot to reenable it on subclasses.
Fixed in next commit.
I should have both included some instructions in the readme (this is fixed now) from the beginning and description in the pull request explaining what have been done. So this ticket introduces configuration for Travis CI, which uses Now as to why replaced standard python |
Sounds great, but still running Got the same result in Python 2.7.15 and 3.6.5 |
and you are sure you have run I had some syntax still messed up in readme, now it should properly render: https://github.com/rooterkyberian/monero-python/blob/ci/README.rst |
Please note you most likely don't want to merge this before #25 .
https://travis-ci.org/rooterkyberian/monero-python/branches
https://coveralls.io/github/rooterkyberian/monero-python