Skip to content

Fixes no-overwrite test failure #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 11, 2020
Merged

Fixes no-overwrite test failure #159

merged 5 commits into from
Jun 11, 2020

Conversation

yangnuoyu
Copy link
Contributor

@olamy , @stephaniewang526

  • fix the problem when parsing version by using "./mvnw -v".
  • fix the problem that we need to use "mvnw.cmd -v" to parse Maven version in Windows
  • fix the problem of checking existing flattened pom resulting from the different line separator in Windows ("\r\n" instead of "\n")

@stephaniewang526
Copy link
Contributor

@olamy PTAL

@lasselindqvist lasselindqvist self-requested a review June 11, 2020 06:07
olamy
olamy approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@olamy olamy merged commit f4d442f into mojohaus:master Jun 11, 2020
@olamy olamy added this to the release:1.2.3 milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

@lasselindqvist lasselindqvist lasselindqvist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release:1.2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@yangnuoyu @stephaniewang526 @olamy @lasselindqvist