flatten error when profiles are activated by property

[farfouille64]

Given the following pom.xml :

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>

  <groupId>org.test</groupId>
  <artifactId>A</artifactId>
  <version>1.0-SNAPSHOT</version>

  <dependencies>
    <dependency>
      <groupId>junit</groupId>
      <artifactId>junit</artifactId>
      <version>4.${revision}</version>
    </dependency>     
  </dependencies>

  <build>
     <plugins>
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>flatten-maven-plugin</artifactId>
         <version>1.1.0</version>
           <executions>
		<execution>
			<id>flatten</id>
			<phase>process-resources</phase>
			<goals>
				<goal>flatten</goal>
			</goals>
			<configuration>
				<embedBuildProfileDependencies>true</embedBuildProfileDependencies>
			</configuration>
		</execution>
	   </executions>
       </plugin>
     </plugins>
  </build>

  <profiles>
     <profile>
        <id>ProfDef</id>
        <activation>
           <property>
              <name>!prof</name>
           </property>
        </activation>
        <properties>
           <revision>10</revision>
        </properties>
     </profile>
     <profile>
        <id>ProfA</id>
        <activation>
           <property>
              <name>prof</name>
           </property>
        </activation>
        <properties>
           <revision>12</revision>
        </properties>
     </profile>
  </profiles>
</project>

flatten succeeds if profiles are activated explicitly (-P option) but fails when they are activated by properties :
mvn process-resources => failure
mvn -Dprof process-resources => failure
mvn -PProfA process-resources => success
mvn -PProfDef process-resources => success
failure message :
[ERROR] 'dependencies.dependency.version' for junit:junit:jar must be a valid version but is '4.${revision}'.

[hunalme]

activeByDefault=true property in profile configuration doesn't work either.

<profiles>
<profile>
<id>TEST</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<properties>
<revision>1.0.1-SNAPSHOT</revision>
</properties>
</profile>
<profile>
<id>PRE</id>
<properties>
<revision>1.0.1-PRE-SNAPSHOT</revision>
</properties>
</profile>
</profiles>

[ashulin]

I have the same problem.

[menneske2]

boy oh boy i sure do love debugging

[dymont]

Nothing new since pratically 3 years?

[jcunliffe1]

maybe this is intentional?

from docu:

profiles	resolved specially	only the Activation and the Dependency dependencies of a Profile are copied to the flattened POM. If you set the parameter embedBuildProfileDependencies to true then only profiles Activation activated by JDK or OS will be added to the flattened POM while the other profiles are triggered by the current build setup and if activated their impact on dependencies is embedded into the resulting flattened POM.

enabledByDefault is not part of that activation list: JDK/OS

[v-chernyshev]

Any update here?

I believe the code contradicts itself. According to this method, a build-time dependency is one that is "neither OS nor JDK":

flatten-maven-plugin/src/main/java/org/codehaus/mojo/flatten/FlattenMojo.java

Lines 964 to 970 in 3474a7c

	protected static boolean isBuildTimeDriven(Activation activation) {
	if (activation == null) {
	return true;
	}
	return StringUtils.isEmpty(activation.getJdk()) && activation.getOs() == null;
	}

The method that creates the final flattened dependencies out of the effective model only considers the dependencies coming from such profiles if the embedBuildProfileDependencies flag is true:

flatten-maven-plugin/src/main/java/org/codehaus/mojo/flatten/FlattenMojo.java

Lines 988 to 1011 in 3474a7c

	if (isEmbedBuildProfileDependencies()) {
	Model projectModel = this.project.getModel();
	Dependencies modelDependencies = new Dependencies();
	modelDependencies.addAll(projectModel.getDependencies());
	for (Profile profile : projectModel.getProfiles()) {
	// build-time driven activation (by property or file)?
	if (isBuildTimeDriven(profile.getActivation())) {
	List<Dependency> profileDependencies = profile.getDependencies();
	for (Dependency profileDependency : profileDependencies) {
	if (modelDependencies.contains(profileDependency)) {
	// our assumption here is that the profileDependency has been added to model because of
	// this build-time driven profile. Therefore we need to add it to the flattened POM.
	// Non build-time driven profiles will remain in the flattened POM with their dependencies
	// and
	// allow dynamic dependencies due to OS or JDK.
	Dependency resolvedProfileDependency = modelDependencies.resolve(profileDependency);
	if (omitExclusions) {
	resolvedProfileDependency.setExclusions(Collections.emptyList());
	}
	flattenedDependencies.add(resolvedProfileDependency);
	}
	}
	}
	}

At the same time, the method that creates the effective model skips every single profile when embedBuildProfileDependencies is true:

flatten-maven-plugin/src/main/java/org/codehaus/mojo/flatten/FlattenMojo.java

Lines 703 to 706 in 3474a7c

	for (Profile profile : effectivePom.getProfiles()) {
	if (!isEmbedBuildProfileDependencies() || !isBuildTimeDriven(profile.getActivation())) {
	if (!isEmpty(profile.getDependencies()) || !isEmpty(profile.getRepositories())) {
	List<Dependency> strippedDependencies = new ArrayList<>();

[v-chernyshev]

Should the check on line 704 be if (isEmbedBuildProfileDependencies() || !isBuildTimeDriven(profile.getActivation())) { instead to always include the "OS or JDK" profiles, and the rest when embedBuildProfileDependencies == true?