Skip to content

fix: update numpy array comparisons to use isin #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

emmanuel-ferdman
Copy link
Contributor

PR Summary

This small PR resolves the deprecation warnings coming from np.in1d:

/home/runner/work/flopy/flopy/flopy/utils/zonbud.py:1031: DeprecationWarning: `in1d` is deprecated. Use `np.isin` instea

Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.1%. Comparing base (7eb7c88) to head (3e99258).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2504      +/-   ##
===========================================
- Coverage     76.1%    56.1%   -20.1%     
===========================================
  Files          296      640     +344     
  Lines        64215   124323   +60108     
===========================================
+ Hits         48885    69747   +20862     
- Misses       15330    54576   +39246     
Files with missing lines Coverage Δ
flopy/utils/zonbud.py 66.8% <ø> (ø)

... and 475 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wpbonelli wpbonelli merged commit 0d9c914 into modflowpy:develop May 6, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants