Skip to content

fix(HeadFile,CellBudgetFile): fix tdis reversal #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

wpbonelli
Copy link
Member

Fix #2459 and expand tests

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.8%. Comparing base (bb9824e) to head (4e11c6b).
Report is 61 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/utils/binaryfile/__init__.py 93.3% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2460     +/-   ##
=========================================
+ Coverage     68.4%   75.8%   +7.4%     
=========================================
  Files          294     293      -1     
  Lines        59390   61905   +2515     
=========================================
+ Hits         40652   46962   +6310     
+ Misses       18738   14943   -3795     
Files with missing lines Coverage Δ
flopy/utils/binaryfile/__init__.py 86.1% <93.3%> (ø)

... and 254 files with indirect coverage changes

@wpbonelli wpbonelli marked this pull request as ready for review February 25, 2025 11:37
@wpbonelli wpbonelli merged commit 39d8d32 into modflowpy:develop Feb 25, 2025
20 of 22 checks passed
@wpbonelli wpbonelli deleted the 2459 branch February 25, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Headfile.reverse() changes time-step indices
1 participant