Skip to content

example: add example in progress #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

example: add example in progress #271

wants to merge 1 commit into from
+723 −3

Conversation

jokemanfire
Copy link
Collaborator

Motivation and Context

add a example to introduce progress

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@github-actions github-actions bot added T-documentation Documentation improvements T-dependencies Dependencies related changes T-config Configuration file changes T-examples Example code changes labels Jun 18, 2025
@jokemanfire jokemanfire mentioned this pull request Jun 18, 2025
Open
@schwifty-brows
Copy link

i see the "simualte getting from a stream" but to really test, i would create a stream and process the resulting stream

@schwifty-brows
Copy link

after that is added and you run the test, you should be able to see the return inconsistency

alexhancock
alexhancock previously approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@alexhancock alexhancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexhancock
Copy link
Contributor

I was able to verify/successfully run the example @schwifty-brows via python3 progress_test_client.py in examples/clients/scripts

Screenshot 2025-06-20 at 11 49 45 AM

Were you running into something different than me?

@schwifty-brows
Copy link

schwifty-brows commented Jun 20, 2025 via email

@github-actions github-actions bot added the T-test Testing related changes label Jun 21, 2025
@jokemanfire
Copy link
Collaborator Author

jokemanfire commented Jun 21, 2025 •
edited
Loading

I think it is not rmcp's problem , I think it should be your business flow problem @schwifty-brows . And I have tested all the transport.

The current example file structure is not very good. In fact, this example is better placed in an integration test. I will modify this structure in another pr. @alexhancock

@schwifty-brows
Copy link

how should we be sending SSE messages back? the progress notification is meant to do this, but running a simple example does not consistently work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexhancock alexhancock alexhancock left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
T-config Configuration file changes T-dependencies Dependencies related changes T-documentation Documentation improvements T-examples Example code changes T-test Testing related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jokemanfire @schwifty-brows @alexhancock