fix: streamable http server close request channel on response(#266) #270
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
T-core
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the streamable HTTP server was not properly releasing resources when a RequestId is removed. The key changes include modifying the logic to close the HTTP channel if its resource list is empty or if the resource is an MCP request, and adding a warning log when the channel is not found.
| @@ -328,11 +328,19 @@ impl LocalSessionWorker { | |||
| if let Some(http_request_id) = self.resource_router.remove(resource) { | |||
| tracing::trace!(?resource, http_request_id, "unregister resource"); | |||
| if let Some(channel) = self.tx_router.get_mut(&http_request_id) { | |||
| channel.resources.remove(resource); | |||
| if channel.resources.is_empty() { | |||
| // It's okey to do so, since we don't handle batch json rcp request anymore | |||
There was a problem hiding this comment.
There is a spelling mistake in the comment: "okey" should be "okay".
Suggested change
| // It's okey to do so, since we don't handle batch json rcp request anymore | |
| // It's okay to do so, since we don't handle batch json rcp request anymore |
Copilot uses AI. Check for mistakes.
crates/rmcp/src/transport/streamable_http_server/session/local.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
jokemanfire
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
release related resource when
RequestIdis removedHow Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context
#268 is for close connection in client side, this pr is for really fix the bug