Skip to content

Fix: computedFn should call onCleanup when computation is not memoized #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wemyss
Copy link
Contributor

@wemyss wemyss commented Apr 2, 2025

Currently when you invoke computedFn outside of a reactive context, the provided onCleanup method is never called. This differs from createTransformer -

if (onCleanup) onCleanup(value, object)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant