-
Notifications
You must be signed in to change notification settings - Fork 36
📈streamline-network-and-si-grap-plot #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, interactions can be filtered by their order
mmschlk
requested changes
Apr 2, 2025
mmschlk
approved these changes
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing @heinzll! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to streamline the
network_plot
function, improve modularity, and enhance test coverage. The most significant changes involve refactoring thenetwork_plot
implementation to delegate functionality tosi_graph_plot
, simplifying its interface, and adding utility functions for better reusability.Refactoring and Simplification:
shapiq/plot/network.py
: Refactored thenetwork_plot
function to delegate most of its functionality tosi_graph_plot
, removing redundant code and simplifying the function's interface. Several arguments, such asfirst_order_values
,second_order_values
, andfeature_image_patches
, were removed, and a generic**kwargs
was introduced to pass additional parameters. [1] [2] [3]Dependency Updates:
pyproject.toml
: Addedpillow
as a dependency to support image processing functionality.Utility Enhancements:
shapiq/plot/utils.py
: Added a new utility functionadd_image_in_center
to handle the addition of images in the center of plots, improving reusability and modularity.Testing Improvements:
tests/conftest.py
: Introduced a new pytest fixture,example_values
, to provide reusable interaction values for testing.tests/tests_plots/test_network_plot.py
: Removed redundant tests fornetwork_plot
that relied on now-deprecated arguments and added reliance onInteractionValues
objects for testing. [1] [2]Code Cleanup:
shapiq/plot/network.py
: Removed unused imports and large blocks of obsolete code related to graph construction and legend management.