Add support for partition in slurm template
#118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakob-r
added a commit
that referenced
this pull request
Sep 25, 2017
* robustify doJobCollection * new backports * Update Travis (#111) * selectively import backports * fix travis * removed remotes from desc * Warn about factors in addExperiments (#112) * fix appveyor * relative path handling * improved docs for reduceResults * paths * added tibble to suggests to check xrefs * improve getLogFiles * fix logs * fixed visibility in shared object * Add support for `partition` in slurm template (#118) Agreed. Thanks for the PR. * fix testJob for win? * simplified path lookup * added some tests * use %chin% * added some comments * docs * docs * fixed a bug where time stamps where rounded to seconds * fixed printing of remaining runtimes * fixed error message * use withr * warn instead of stop on the master if not all depenencies are satisfied (fixes #122) * fix travis * removeExperiments returns ids invisibly * fix heuristic of getJobPars * improved message * always use winslash * file.path/winslash * vignettes * updated README [ci skip] * updated README [ci skip] * docs * depend on withr 2.0.0 * Job names (#124) * updated NEWS * increase version number for CRAN release * vignette and docs * vignette * docs * NEWS formating * docs * increase version number after CRAN release * improved docs of reduceResults (fixes #116) * fix for #135 * added test, fixes #135 * fix test * README * small fix in printer * read-only mode (#137) * ClusterFunctions rework: Do not swallow system errors (#138) * added update routine for job.name * NEWS * improved control over sleep duration; nodename in cfSlurm * Wait for jobs rework (#140) * wait for brewed file before submit * version, docs * increased version after release * updated travis * fix links in vignette (#142) * version 0.9.6 * added test for algo caching * test for PM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an idea to enable a user to easily adjust the
partitionthey submit to on a slurm cluster. On my cluster, you can't leave partition blank.I can just use my own templates, I know, but thought you might find this useful. If no
partitionvariable is provided in theresourceslist, it doesn't change anything.