Skip to content

Remaining small fixes #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025
Merged

Remaining small fixes #281

merged 4 commits into from
Jun 10, 2025

Conversation

frontsideair
Copy link
Collaborator

@frontsideair frontsideair commented Jun 10, 2025

Tweaked the hero section whitespace again, this has much better visual balance now and more faithful to the Figma design. Tested on mobile as well.

Had to reapply the header background fix, as it was lost during merge: #272

Also fixed horizontal scroll in mobile menu, and fixed the wrong xxs breakpoint.

Screenshot 2025-06-10 at 12 59 40 Screenshot 2025-06-10 at 13 00 15 Screenshot 2025-06-10 at 13 00 28 Screenshot 2025-06-10 at 13 00 47 Screenshot 2025-06-10 at 13 01 00 Screenshot 2025-06-10 at 13 01 14 Screenshot 2025-06-10 at 13 01 27

Copy link

github-actions bot commented Jun 10, 2025

Preview for 6cf9643

  • For faster build, the doc pages are not included in the preview.
  • Redirects are disabled in the preview.
Open in StackBlitz

This was merged but lost during a merge conflict most likely
#272
@frontsideair
Copy link
Collaborator Author

Sticky image fade-in on scroll

recording.mov

Copy link
Collaborator

@daniellok-db daniellok-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm but can we increase the transition time for the fade in/out? it feels a bit too fast, like it's blinking

edit: ah i see it's not doing a fade out, only a fade in. maybe if we add a fade out effect it would help smooth it

Copy link
Collaborator

@daniellok-db daniellok-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@daniellok-db daniellok-db merged commit e4f4504 into main Jun 10, 2025
8 checks passed
@daniellok-db daniellok-db deleted the various-fixes-3 branch June 10, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants