Skip to content

Add delete tag endpoint #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Add delete tag endpoint #8

merged 6 commits into from
Oct 8, 2024

Conversation

nojaf
Copy link
Collaborator

@nojaf nojaf commented Oct 2, 2024

I've add a simple endpoint and some steps of how I did it.
Please review and don't be shy to add remarks on the markdown!

@jescalada
Copy link
Contributor

We could also add a section for performance-related considerations. Since we are porting to Go for performance reasons (?), there are times where we don't want to do things exactly like they're done in Python? Maybe we can add some actual examples of rewriting existing logic to make it more efficient or idiomatic.

@jescalada jescalada mentioned this pull request Oct 4, 2024
Copy link
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a second, in-depth review of the guide from going through all the steps as a Go newbie. Feel free to take them or leave them as needed :)

@nojaf nojaf requested a review from jescalada October 7, 2024 14:51
Signed-off-by: nojaf <[email protected]>
Copy link
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guide looks great! Just had some minor wording changes (and index fix).

Co-authored-by: Juan Escalada <[email protected]>
Signed-off-by: Florian Verdonck <[email protected]>
Copy link
Collaborator

@dsuhinin dsuhinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Nice job!

@nojaf nojaf merged commit e64cf62 into mlflow:main Oct 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants