-
Notifications
You must be signed in to change notification settings - Fork 7
Add delete tag endpoint #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We could also add a section for performance-related considerations. Since we are porting to Go for performance reasons (?), there are times where we don't want to do things exactly like they're done in Python? Maybe we can add some actual examples of rewriting existing logic to make it more efficient or idiomatic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a second, in-depth review of the guide from going through all the steps as a Go newbie. Feel free to take them or leave them as needed :)
Signed-off-by: nojaf <[email protected]>
Signed-off-by: nojaf <[email protected]>
Signed-off-by: nojaf <[email protected]>
Signed-off-by: nojaf <[email protected]>
Signed-off-by: nojaf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guide looks great! Just had some minor wording changes (and index fix).
Co-authored-by: Juan Escalada <[email protected]> Signed-off-by: Florian Verdonck <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Nice job!
I've add a simple endpoint and some steps of how I did it.
Please review and don't be shy to add remarks on the markdown!