Fix failing pipelines and update codebase to go 1.24 #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkubaczyk
changed the title
rvbcia
pushed a commit
to rvbcia/helmsman
that referenced
this pull request
Apr 1, 2025
* Update codebase to go 1.24 * Update kubectl download url in Dockerfile
luisdavim
pushed a commit
that referenced
this pull request
Apr 13, 2025
* Add --verify flag to helm commands - Introduced a new --verify flag to the command-line interface in Helmsman. - Updated the helmCmd function in internal/app/helm_helpers.go to append the --verify flag to helm commands when specified. - Modified cmd/helmsman/main.go to handle the --verify flag. - Added logic to set and use the verify flag in internal/app/main.go. This change allows users to verify the downloaded charts using the --verify flag during Helmsman operations. * Add --verify flag to helm commands - Introduced a new --verify flag to the command-line interface in Helmsman. - Updated the helmCmd function in internal/app/helm_helpers.go to append the --verify flag to helm commands when specified. - Modified internal/app/cli.go to define and parse the --verify flag. - Modified internal/app/main.go to handle the --verify flag and set it in helm_helpers. This change allows users to verify the downloaded charts using the --verify flag during Helmsman operations. * Fix --verify flag usage for helm commands - Updated the helmCmd function in internal/app/helm_helpers.go to only append the --verify flag to specific Helm commands (install, upgrade, pull). - Ensured that the --verify flag is not added to commands like helm version, which do not support it. This change ensures that the --verify flag is only used with appropriate Helm commands. * Update cli_test.go Added tests * Add documentation for the --verify flag * Add documentation for the --verify flag * Run go fmt * Fix failing pipelines and update codebase to go 1.24 (#945) * Update codebase to go 1.24 * Update kubectl download url in Dockerfile * Release v3.18.0 * Change global variable to struct * Refactor: Align `flags.verify` handling with existing patterns - Updated `flags.verify` to be set using the `SetVerifyFlag` method in the `HelmHelper` struct. - Removed any direct handling of `flags.verify` outside of the `HelmHelper` instance. - Ensured consistency with the existing pattern for flag handling in the `Main` function. - Improved code readability and maintainability by avoiding global variable usage. * Run go fmt * Refactor: Simplify `verifyFlag` handling in `HelmHelper` and `Main` - Removed the `SetVerifyFlag` method from `HelmHelper` as it was unnecessary. - Updated `Main` to directly set the `verifyFlag` field in the `HelmHelper` instance. - Simplified the code by avoiding over-engineering and aligning with a more direct approach. * Removed unnecessary comments, including those in Polish, for a cleaner codebase. --------- Co-authored-by: Mateusz Kubaczyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address failing builds from recent days - some packages required golang >= 1.23. I went a bit further and decided it's worth updating straight to 1.24.x and with that I also updated all the dependencies.
Download url for kubectl changed, I could not get version 1.32.x from the previous one, so I followed the official docs for the curl installation method.
Even though tests are fine now, I'd appreciate running the build against existing clusters just to confirm everything is fine.