[POC] Add downbeats to waveform #14835
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current UI:
Modified UI:
There are 3 new buttons:
Information, Implementation details and doubts
First of all, when reviewing take in consideration that I am mainly Javascript developer. Just tired of getting the down beat wrong, then I faced c++ here. And this implementation already solve almost all my use cases.
The main concept here is the creation of a new
waveformrenderdownbeat
class, this is basically a copy ofwaveformrenderbeat
but only rendering the down beats. Doing this way is less disruptive and is not messing with old code.It shows 4 and 8 beats differently, 8ths are generated with little triangle on top.
There is a new skin parameter for setting the downbeat color.
This will work only on 4/4 songs right now.
This will only work with [x] use acceleration
It needs a way to store the downbeatoffset after user move it.
__
m_beatOffset
frombeats.cpp
. Is there already other way to do this?