With statements cannot be used with the "esm" output format due to strict mode

[cheetahbyte]

> node_modules/domino/lib/sloppy.js:10:4: error: With statements cannot be used with the "esm" output format due to strict mode
    10 │     with(this) eval(code);
       ╵     ~~~~

 > node_modules/domino/lib/sloppy.js:14:6: error: With statements cannot be used with the "esm" output format due to strict mode
    14 │       with(this.document.defaultView || Object.create(null))
       ╵       ~~~~

 > node_modules/domino/lib/sloppy.js:15:8: error: With statements cannot be used with the "esm" output format due to strict mode
    15 │         with(this.document)
       ╵         ~~~~

 > node_modules/domino/lib/sloppy.js:16:10: error: With statements cannot be used with the "esm" output format due to strict mode
    16 │           with(this.form)
       ╵           ~~~~

 > node_modules/domino/lib/sloppy.js:17:12: error: With statements cannot be used with the "esm" output format due to strict mode
    17 │             with(this.element)
       ╵             ~~~~

error when starting dev server:
Error: Build failed with 5 errors:
node_modules/domino/lib/sloppy.js:10:4: error: With statements cannot be used with the "esm" output format due to strict mode
node_modules/domino/lib/sloppy.js:14:6: error: With statements cannot be used with the "esm" output format due to strict mode
node_modules/domino/lib/sloppy.js:15:8: error: With statements cannot be used with the "esm" output format due to strict mode
node_modules/domino/lib/sloppy.js:16:10: error: With statements cannot be used with the "esm" output format due to strict mode
node_modules/domino/lib/sloppy.js:17:12: error: With statements cannot be used with the "esm" output format due to strict mode
    at failureErrorWithLog (C:\Users\user\AppData\Roaming\npm\node_modules\vite\node_modules\esbuild\lib\main.js:1224:15)
    at buildResponseToResult (C:\Users\user\AppData\Roaming\npm\node_modules\vite\node_modules\esbuild\lib\main.js:936:32)
    at C:\Users\Leonhard Breuer\AppData\Roaming\npm\node_modules\vite\node_modules\esbuild\lib\main.js:1035:20
    at C:\Users\Leonhard Breuer\AppData\Roaming\npm\node_modules\vite\node_modules\esbuild\lib\main.js:568:9
    at handleIncomingPacket (C:\Users\user\AppData\Roaming\npm\node_modules\vite\node_modules\esbuild\lib\main.js:657:9)
    at Socket.readFromStdout (C:\Users\user\AppData\Roaming\npm\node_modules\vite\node_modules\esbuild\lib\main.js:535:7)
    at Socket.emit (events.js:315:20)
    at addChunk (internal/streams/readable.js:309:12)
    at readableAddChunk (internal/streams/readable.js:284:9)
    at Socket.Readable.push (internal/streams/readable.js:223:10)
    ```
    I get this error, how can I fix it?

[logycware]

Having the same problem

[damianmozniak]

Having the same problem

[martincizek]

There are some packaging changes in the master, so I'd like to ask you to try it first, i.e.:

  "dependencies": {
    "turndown": "github:domchristie/turndown"
  }

If the issue is still present, please provide a minimum buildable example reproducing the issue. Including:

• package.json (or other build config file)
• your Node.js version
• a minimum script
• instructions if applicable

Thank you!

[callmeberzerker]

Hi @martincizek

The entry points for "turndown": "github:domchristie/turndown" are wrong.

There is no lib folder like referenced here in package.json from master:

"main": "lib/turndown.cjs.js",
"module": "lib/turndown.es.js",
"jsnext:main": "lib/turndown.es.js",

[damianmozniak]

@martincizek solution works for me

[callmeberzerker]

@damianmozniak not sure how since there is no lib folder?

[damianmozniak]

@callmeberzerker lib exist after npm install so it's configured somewhere

[martincizek]

So it seems it was PR #335 what fixes this (merged but not released to npmjs).

We're currently in a process of transferring Turndown under a new organisation and I hope I'll be able to release a new npm package soon.

[callmeberzerker]

To anyone to whom this is a blocker and is using yarn as their package manager - I have published the latest master and the dist and lib folders on my forked version.

You would need to add the following to your dependencies:

"turndown": "https://github.com/callmeberzerker/turndown/commit/ede17b4aee0ee12c1615d65b28f64b9aa3e2b7e8"

Hopefully the proper version is released as soon as possible.

The maintainer published a temp branch see here: #378 (comment)

[martincizek]

To anyone to whom this is a blocker and is using yarn as their package manager - I have published the latest master and the dist and lib folders on my forked version.

@callmeberzerker Not sure how this differ from the current master. I see three commits in your fork:

1. You've commited generated stuff, which is not necessary, because dependencies are built automatically when linked as a git dependency.
2. You've introduced a mistake in package.json
3. You've fixed your mistake from previous commit :-), which leads to the same package.json as in Turndown's master (except the script externalisation, which should be irrelevant for the functionality).

Are you sure that the result is any different from using just:

  "dependencies": {
    "turndown": "github:domchristie/turndown"
  }

?

P.S. Don't forget to npm install in your project, that's what also builds the turndown dependency.

[callmeberzerker]

Hi @martincizek

As I explained in previous comment, I am not using npm - but yarn (version 1) -> I basically need the published lib files irrelevant of my build/package manager. That's why I can't rely on "turndown": "github:domchristie/turndown" to be then run with npm to get the generated files.

[martincizek]

As I explained in previous comment, I am not using npm - but yarn (version 1) -> I basically need the published lib files irrelevant of my build/package manager.

I see. Not very familiar with yarn, I guess it's because of yarnpkg/yarn#5235, right?

I've created a temporary branch with pre-built artifacts as a workaround until a new npm package is published. Would you mind to test it?

Workaround for yarn version 1:

  "dependencies": {
    "turndown": "github:domchristie/turndown#build-7.1"
  }

[callmeberzerker]

First of all, thanks a lot for your prompt feedback and communication!

I can definitely confirm that it works with your branch -> I will edit my above comment to point your comment.

I know the whole node/js ecosystem is hurting big now with the esm/module/main semi-standardization going on now which is hell for lib authors and users - but we will get through it somehow!

Once again thanks a lot!

[cheetahbyte]

Since my bug is fixed, and everyone else seems to be happy too, I'll close the issue :D