-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add ol-openedx-course-sync plugin #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not a full code review, but I skimmed through the code and it looks fine to me.
I tested this on multiple scenarios and it works fine as per my testing.
- Tested it with different course outline units
- Tested it with a mix of published and draft outlines
- Tested it with the grading policy, and that also gets copied into re-runs
- Tested the progress as a student in a re-run, and that worked fine too
- Tested with large courses, it does take some time, but it works for them too
- Tested it with course re-runs for different organizations, and it worked, Although it takes some time.
We will have to make some optimizations here. Ideally, run the copy operation in celery tasks. It would be great if we could use the same mechanism as edX's Insturctor Tasks/Model to be able to trace errors and progress via the instructor tasks API if needed.
Sure, I will refine code + do this once I get a go ahead. |
15dead2
to
ba29b9d
Compare
490f95f
to
4872c3a
Compare
428f22a
to
07b29ca
Compare
e82072e
to
0f314a1
Compare
0f314a1
to
591ae38
Compare
What are the relevant tickets?
https://github.com/mitodl/hq/issues/7197
Description (What does it do?)
Adds a new plugin to sync changes from one course to other courses named
ol-openedx-course-sync
.How can this be tested?
Course Sync Parent Orgs
andCourse Sync Maps
Course Sync Parent Orgs
.Course Sync Maps
and verify the newly added entry. Verify the source course and target course values.