-
Notifications
You must be signed in to change notification settings - Fork 2
Edx verified force enrollment after enrollment end date #1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edx verified force enrollment after enrollment end date #1225
Conversation
045428d
to
9214170
Compare
Codecov Report
@@ Coverage Diff @@
## main #1225 +/- ##
==========================================
- Coverage 83.18% 83.18% -0.01%
==========================================
Files 297 297
Lines 11957 11962 +5
Branches 815 816 +1
==========================================
+ Hits 9947 9950 +3
- Misses 1783 1786 +3
+ Partials 227 226 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
9214170
to
9086ca1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm. Awesome work! Just a small change is suggested. Also, Can we write tests for forced enrollments? Is there any need for that? WDYT?
9086ca1
to
9a688f0
Compare
Pre-Flight checklist
app.json
What are the relevant tickets?
#1179
What's this PR do?
Follow-up PR for #1129
How should this be manually tested?
(Required)
Where should the reviewer start?
(Optional)
Any background context you want to provide?
(Optional)
Screenshots (if appropriate)
(Optional)