Skip to content

Edx verified force enrollment after enrollment end date #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aliraza-abbasi
Copy link
Contributor

Pre-Flight checklist

  • Screenshots and design review for any changes that affect layout or styling
    • Desktop screenshots
    • Mobile width screenshots
  • Migrations
    • Migration is backward-compatible with the current production code
  • Testing
    • Code is tested
    • Changes have been manually tested
  • Settings
    • New settings are documented and present in app.json
    • New settings have reasonable development defaults, if applicable
    • Opened issue for DevOps regarding necessary configuration changes to deployed environments

What are the relevant tickets?

#1179

What's this PR do?

Follow-up PR for #1129

How should this be manually tested?

(Required)

Where should the reviewer start?

(Optional)

Any background context you want to provide?

(Optional)

Screenshots (if appropriate)

(Optional)

@odlbot odlbot temporarily deployed to mitxonline-ci-pr-1225 November 17, 2022 13:57 Inactive
@aliraza-abbasi aliraza-abbasi force-pushed the aliraza/issue-1179-create-forced-verified-enrollment branch from 045428d to 9214170 Compare November 18, 2022 13:15
@odlbot odlbot temporarily deployed to mitxonline-ci-pr-1225 November 18, 2022 13:16 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #1225 (9086ca1) into main (c15b8e0) will decrease coverage by 0.00%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
- Coverage   83.18%   83.18%   -0.01%     
==========================================
  Files         297      297              
  Lines       11957    11962       +5     
  Branches      815      816       +1     
==========================================
+ Hits         9947     9950       +3     
- Misses       1783     1786       +3     
+ Partials      227      226       -1     
Impacted Files Coverage Δ
openedx/api.py 85.76% <50.00%> (-0.88%) ⬇️
courses/api.py 88.11% <100.00%> (ø)
ecommerce/models.py 85.83% <0.00%> (ø)
ecommerce/views/v0/__init__.py 90.00% <0.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aliraza-abbasi aliraza-abbasi force-pushed the aliraza/issue-1179-create-forced-verified-enrollment branch from 9214170 to 9086ca1 Compare December 7, 2022 10:54
Copy link
Contributor

@asadali145 asadali145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Awesome work! Just a small change is suggested. Also, Can we write tests for forced enrollments? Is there any need for that? WDYT?

@aliraza-abbasi aliraza-abbasi force-pushed the aliraza/issue-1179-create-forced-verified-enrollment branch from 9086ca1 to 9a688f0 Compare December 8, 2022 14:01
@aliraza-abbasi aliraza-abbasi merged commit e0742f7 into main Dec 15, 2022
@aliraza-abbasi aliraza-abbasi deleted the aliraza/issue-1179-create-forced-verified-enrollment branch December 15, 2022 13:05
@odlbot odlbot mentioned this pull request Dec 15, 2022
4 tasks
@odlbot odlbot mentioned this pull request Dec 16, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants