Skip to content

Exclude suspended users note from most timelines #15775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

anatawa12
Copy link
Member

What

Fix #14727

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link
Contributor

github-actions bot commented Apr 7, 2025

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 8.33333% with 77 lines in your changes missing coverage. Please review.

Project coverage is 42.58%. Comparing base (a3d236c) to head (0cc08ff).
Report is 1141 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/QueryService.ts 18.18% 18 Missing ⚠️
.../backend/src/core/FanoutTimelineEndpointService.ts 5.55% 17 Missing ⚠️
packages/backend/src/core/SearchService.ts 0.00% 14 Missing ⚠️
...ackend/src/server/api/endpoints/users/reactions.ts 0.00% 6 Missing ⚠️
...backend/src/server/api/endpoints/notes/featured.ts 25.00% 3 Missing ⚠️
...d/src/server/api/endpoints/users/featured-notes.ts 25.00% 3 Missing ⚠️
...es/backend/src/server/api/endpoints/clips/notes.ts 0.00% 2 Missing ⚠️
...es/backend/src/server/api/endpoints/users/notes.ts 0.00% 2 Missing ⚠️
...backend/src/server/api/endpoints/antennas/notes.ts 0.00% 1 Missing ⚠️
...kend/src/server/api/endpoints/channels/timeline.ts 0.00% 1 Missing ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15775      +/-   ##
===========================================
+ Coverage    41.74%   42.58%   +0.84%     
===========================================
  Files         1549     1681     +132     
  Lines       196555   170518   -26037     
  Branches      2767     4210    +1443     
===========================================
- Hits         82055    72619    -9436     
+ Misses      113939    97408   -16531     
+ Partials       561      491      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anatawa12 anatawa12 force-pushed the suspended-users-note branch from f367a6c to e314aac Compare April 7, 2025 16:04
Comment on lines +88 to -89
this.queryService.generateVisibilityQuery(query, me);
// this.queryService.generateSuspendedUserQueryForNote(query); // To avoid problems with removing notes, ignoring suspended user for now
if (me) {
this.queryService.generateVisibilityQuery(query, me);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

明らかな実装ミスに感じたのでついでに public clip の表示権限のないノートはログインされてないときも見えないようにしました

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

TL取得時に凍結されたユーザーの投稿を表示しないようにする
1 participant