Skip to content

FIX[123] Specify json format only when necessary #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2020

Conversation

ngouy
Copy link
Contributor

@ngouy ngouy commented Oct 2, 2020

Now json format doesn't include fixed code anymore. So I removed it from "getCommandArgs" and use it only when required

tested (on my machine) against rubocop v90 and 92, works on both

Fixes #129

@ngouy ngouy marked this pull request as ready for review October 2, 2020 19:55
@ndbroadbent
Copy link

ndbroadbent commented Oct 15, 2020

Thanks @ngouy!! I just upgraded to RuboCop 0.93.1 so this is really helpful!

Until this is merged and released, here are the commands I ran to install the fork locally:

Make sure you uninstall the official RuboCop extension first.

cd ~/code
git clone https://github.com/ngouy/vscode-ruby-rubocop.git
cd vscode-ruby-rubocop
git checkout FIX-129-use-json-format-if-necessary
yarn install
npm install -g vsce
vsce package
code --install-extension ruby-rubocop-*.vsix

See also: https://code.visualstudio.com/api/working-with-extensions/publishing-extension

Now "format on save" is working again!


P.S. If anyone doesn't know about this already, I also highly recommend checking out: https://github.com/fohte/rubocop-daemon
This makes my "format on save" work extremely fast, because it keeps a copy of rubocop running in the background.
You should try setting up the bash wrapper script: https://github.com/fohte/rubocop-daemon#more-speed

@jpaas
Copy link

jpaas commented Oct 26, 2020

Bump. Any reason why this is not getting merged?

@ngouy
Copy link
Contributor Author

ngouy commented Oct 26, 2020

I guess unavailable maintainer ATM?

@misogi
Copy link
Owner

misogi commented Nov 7, 2020

Thanks for great contributing!

@misogi misogi merged commit cc960bd into misogi:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on autocorrect with rubocop >=0.91
4 participants