Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Terraform AWS provider to v4.x #291

Merged
merged 4 commits into from
Apr 7, 2022
Merged

Upgrade Terraform AWS provider to v4.x #291

merged 4 commits into from
Apr 7, 2022

Conversation

ofhouse
Copy link
Member

@ofhouse ofhouse commented Mar 31, 2022

Changes

  • Rewrite S3 config to use the new resources
  • Update examples

Fixes #286.

@ofhouse ofhouse added this to the Upcoming Minor milestone Mar 31, 2022
@khuezy
Copy link

khuezy commented Apr 1, 2022

This error is occurring in the last few PRs:

 Module not found: Error: Can't resolve 'encoding' in '/tmp/39a10d8/node_modules/node-fetch/lib

Is there some caching issue w/ the build pipeline?

@ofhouse
Copy link
Member Author

ofhouse commented Apr 1, 2022

@khuezy No, not a caching-issue.
The error is caused when building a text fixture that uses Next.js 7 (which is pretty old 😅).

Don't know why this issue occurred now since the affected packages isomorphic-unfetch & node-fetch were not updated recently.
However adding the encoding dependency solves the issue: af6548e

Another change made by the Vercel team recently when jumping from v12.1.2 to v12.1.3 was the introduction of route manifest version 4 (was 3 before).
Since our builder expects a version <= 3 it crashed during the build for the recent builds, this will be fixed in #292.

@ofhouse ofhouse force-pushed the terraform-aws-v4 branch from f1cf5b5 to b98d66f Compare April 1, 2022 17:51
@ofhouse ofhouse force-pushed the terraform-aws-v4 branch from b98d66f to 6b75c91 Compare April 7, 2022 17:01
@ofhouse ofhouse merged commit 9f453ba into main Apr 7, 2022
@ofhouse ofhouse deleted the terraform-aws-v4 branch April 7, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform AWS 4.0 Provider Upgrade
2 participants