-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lualine): add spinner component #62
feat(lualine): add spinner component #62
Conversation
Thanks for contributing to minuet! I like the idea of adding the two user events I want to note that for As such, you may face the race conditions that So instead of launching the For each {
provider = "openai_compatible", -- or others
name = "fireworks", -- or others, specified from provider_options
n_requests = 3, -- depending on how many jobs are launched
request_idx = 1, -- the request idx out of n_requests
job = job -- the plenary job itself,
}
This also makes implementing the lualine spinner trickier, as I think we need to add an indexer to indicates how many requests are completed (something like Thanks. |
@milanglacier i've changed code based on your feedback, except we cannot pass the job itself to user event. |
@milanglacier could you help to review again? |
Hi, sorry for the late reply. I was working on the new feature (in-process LSP) recently and don't have time to review the code. |
Can you also fire those events for Beside you can pass job itself to the event, like this:
Thanks! |
@milanglacier i've fired those events for Gemini & Claude backends. for passing the job, i know where to pass it, but looks like we cannot pass the job directly to user event, here's the error i got:
|
thanks for the update. It seems like this is a lua <-> vimscript interop issue? can you try to wrap the job inside a function and see if it works? something like this |
@milanglacier wrapping the job inside a function works 👍 , i've updated the code. |
thanks for update. the code looks okay to me. I will pull your branch to local and test it for a while. Once it works fine on my local, and I can merge it. |
Thanks for the updates. I will merge this to a dev branch, and make some updates including README and some tiny tweak like names, then will merge it to main. |
I have merged it into the main branch. There are a few updates:
Thanks again for contribution! |
MinuetRequestStarted
andMinuetRequestFinished
when job started & finishedUsage: