Fix LogDefault output on mingw #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikke89
reviewed
Apr 17, 2025
Source/Core/LogDefault.cpp
Outdated
| @@ -37,7 +37,7 @@ | |||
|
|
|||
| namespace Rml { | |||
|
|
|||
| #ifdef RMLUI_PLATFORM_WIN32 | |||
| #if defined(RMLUI_PLATFORM_WIN32) && !defined(__MINGW32__) | |||
There was a problem hiding this comment.
Hey, and thanks for the pull request! I believe this condition should match the one for the includes above. Perhaps make a new definition with the conditions, to avoid repeating them in both places?
There was a problem hiding this comment.
Yep, I've added a RMLUI_PLATFORM_WIN32_NATIVE macro and applied it to similar cases
Provides windows platform define with the exclusion of mingw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation for win32 won't produce any console output on mingw.
fprintfworks fine.