Improve archive handling #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies the existing zip file extraction implementation to behave the same way on both WIN32 and POSIX platforms. Signed-off-by: Shawn M. Chapla <[email protected]>
Signed-off-by: Shawn M. Chapla <[email protected]>
Extract all files contained a zip archive as temporary files and attempt to open all those files when opening that archive. Signed-off-by: Shawn M. Chapla <[email protected]>
Signed-off-by: Shawn M. Chapla <[email protected]>
|
Thanks Shawn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset simplifies and expands existing zip file opening capabilities by removing unnecessary platform specific code, adding the ability to open archives containing more than one trace file, and performing cleanup of generated temporary files once they are no longer needed.