iPhone heating up

[carlmachaalani]

Hey!

Thank you for starting this project, this has been the only package that actually worked for me so far.

While the streaming is working perfectly, my iPhone 14 heats up after some usage. Not sure if it's an issue from my code or the package. Have you had this issue ?

Thanks!

[dustin-kl]

Hey! I have exactly the same issue here. It's the only library that works for my streaming (so great job) but my phone gets very hot.

What i have inspected so far is the following behavior. The CPU usage is fine for a while (it's low and constant). At some point it will have more and more CPU usage and it keeps accumulating until it hits 80-100% and the phone turns into a heating boiler.

The threads which are doing a lot of work when the CPU usage is that high are always caught up in the function "provideMediaDataIfNeeded". So maybe something is wrong here.

I couldnt find a pattern though of the point in which it starts accumulating...

Thanks a lot!

[stefanteulon]

Same issue here, which is a shame because this is the only repo that works for my use case (that I've found), and the battery hit is going to be too high to use it, unfortunately.

[dustin-kl]

It appears that the issue occurs in the provideMediaDataIfNeeded function, specifically within the requestMediaDataWhenReady closure. Occasionally, it seems to execute indefinitely without stopping.

To resolve this, you can add the following lines of code to the top of the invalidate function in the synchronizer class, which will stop the closure from running:

audioRenderer?.stopRequestingMediaData()
if let audioRendererFixed = audioRenderer {
    audioSynchronizer?.removeRenderer(audioRendererFixed, at: CMTime(value: 0, timescale: 0)) 
}

This should resolve the issue i think. At least my phone didnt get hot after having an 1 hour phone call.

[stefanteulon]

You mean like this?

func invalidate() {
        audioRenderer?.stopRequestingMediaData()
        if let audioRendererFixed = audioRenderer {
            audioSynchronizer?.removeRenderer(audioRendererFixed, at: CMTime(value: 0, timescale: 0))
        }
        removeBuffers()
        closeFileStream()
        cancelObservation()
        receiveComplete = false
        audioSynchronizer = nil
        audioRenderer = nil
    }

[dustin-kl]

Yes exactly. However I think this alone makes the error just less likely, from what I see it can still loop in the provideMediaDataIfNeeded while loop.

I added now an additional bool shouldProvidingData in this while loop that breaks out of this loop.

while audioRenderer.isReadyForMoreMediaData && shouldProvidingData {
            if let buffer = audioBuffersQueue?.dequeue() {
                print("dequeue and enque buffer")
                audioRenderer.enqueue(buffer)
                startPlaybackIfCan(
                    audioRenderer: audioRenderer,
                    audioSynchronizer: audioSynchronizer
                )
            } else if receiveComplete {
                audioRenderer.stopRequestingMediaData()
                break
            }
        }

Now it works for me I have 5 phones running simultaneously and they all stay cold. It's more a hacky solution but it works :))

[stefanteulon]

Awesome, where are you managing the state of shouldProvidingData to toggle between true and false?

[dustin-kl]

Its in the AudioSynchronizer class

private var shouldProvidingData: Bool = true

Then i set it to false in my invalidate function

public func invalidate() {
        audioRenderer?.stopRequestingMediaData()
        if let audioRendererFixed = audioRenderer {
            audioSynchronizer?.removeRenderer(audioRendererFixed, at: CMTime(value: 0, timescale: 0)) // If you're dynamically adding/removing renderers
        }
        shouldProvidingData = false
        
        removeBuffers()
        closeFileStream()
        cancelObservation()
        receiveComplete = false
        audioSynchronizer = nil
        audioRenderer = nil
    }

[stefanteulon]

Thanks, looks like you might have named shouldProvidingData incorrectly as shouldProvideDataGlobal in the invalidate() function

[dustin-kl]

Ah you're right I renamed everything to global in my code but renamed it back to the original name here to stay consistent with the chat.
thanks!

[stefanteulon]

Before I open a new ticket, do you get any audible clipping sounds on your playback when on the device? Like short popping noises and the voice skips a little, I guess between data packets? They don't appear on the simulator, only when on the device itself.

[dustin-kl]

No I dont experience that. At least not as a problem of the audio player. I once had that my voice generator was too slow in generating the next chunks such that there was an audible gap. But I guess that is not a problem of the audio player

[mihai8804858]

Thanks all for the provided info, this has been very useful.
Would any of you be able to test a fix from this branch and let me know if it helped? - https://github.com/mihai8804858/swift-chunked-audio-player/tree/fix-infinite-loop

[dustin-kl]

Seems to work fine, i tested it for 1 hour and the phone didnt heat up. I'll let you know if things change.
Thanks!

[stefanteulon]

I've integrated these changes. Will let you know but so far so good!

[mihai8804858]

Thanks, changes have been released in 1.0.1