Skip to content

- adds missing navigation properties on composable functions in java #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 15, 2020

Conversation

baywet
Copy link
Member

@baywet baywet commented Sep 14, 2020

Summary

composable functions allow to navigate to the return type's navigation properties and so on.
This PR adds missing navigation properties on composable functions

Generated code differences

microsoftgraph/msgraph-sdk-java#466

Command line arguments to run these changes

Provide the command line arguments here so that reviewers can quickly repro the results of changes.

Links to issues or work items this PR addresses

@baywet baywet self-assigned this Sep 14, 2020
@baywet baywet requested a review from nikithauc September 14, 2020 18:10
Copy link
Contributor

@zengin zengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider improving the test data with composable functions as it seems that our current test metadata didn't have that.

@zengin
Copy link
Contributor

zengin commented Sep 15, 2020

Thanks for investing time to improve the test data, really appreciate it.

@baywet baywet merged commit 579dcb3 into dev Sep 15, 2020
@baywet baywet deleted the feature/composable-functions-properties-java branch September 15, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants