You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do we need any applicability check to decide whether we have PUT available or not? It seems like the .NET version generates PutAsync() only on references. I am trying to understand if .NET needs fixing or if we need a guard in Java to generate only for references.
we had a quit chat about that with @darrelmiller this morning.
As far as we know, there's no official annotation to indicate support or non support of the method.
We could inject our own custom annotation via XSLT, and then code gen the methods based on that annotation to make it more precise.
Going through all the entities to check which ones support PUT or not is going to be a painful exercise though.
the other factor is that Java doesn't support partial classes or extensions methods, making it difficult to make a "one off" addition to what's codegen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
the java SDK was missing put methods for entity requests. This PR fixes it.
Generated code differences
microsoftgraph/msgraph-sdk-java#446
Command line arguments to run these changes
Provide the command line arguments here so that reviewers can quickly repro the results of changes.
Links to issues or work items this PR addresses