Skip to content

- fixes a bug where url options would be inserted twice for collection POST requests #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@ import <#=mainNamespace#>.<#=c.GetPackagePrefix()#>.<#=c.TypeName()#>;
final String requestUrl = getBaseRequest().getRequestUrl().toString();
final ReferenceRequestBody body = new ReferenceRequestBody(getBaseRequest().getClient().getServiceRoot() + "/<#=prop#>/<#=implicitNavigationProperty#>" + new<#=c.TypeName()#>.id);
new <#=c.TypeWithReferencesRequestBuilder()#>(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(new<#=c.TypeName()#>, body, callback);
}

public <#=c.TypeName()#> post(final <#=c.TypeName()#> new<#=c.TypeName()#>) throws ClientException {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
final ReferenceRequestBody body = new ReferenceRequestBody(getBaseRequest().getClient().getServiceRoot() + "/<#=prop#>/<#=implicitNavigationProperty#>" + new<#=c.TypeName()#>.id);
return new <#=c.TypeWithReferencesRequestBuilder()#>(requestUrl,getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(new<#=c.TypeName()#>, body);
}
<# }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,14 @@ import <#=mainNamespace#>.<#=TypeHelperJava.GetPrefixForRequests()#>.<#=c.TypeCo
public void post(final <#=c.TypeName()#> new<#=c.TypeName()#>, final ICallback<<#=c.TypeName()#>> callback) {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
new <#=c.TypeRequestBuilder()#>(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(new<#=c.TypeName()#>, callback);
}

public <#=c.TypeName()#> post(final <#=c.TypeName()#> new<#=c.TypeName()#>) throws ClientException {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
return new <#=c.TypeRequestBuilder()#>(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(new<#=c.TypeName()#>);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,14 @@ public ICallCollectionPage get() throws ClientException {
public void post(final Call newCall, final ICallback<Call> callback) {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
new CallRequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newCall, callback);
}

public Call post(final Call newCall) throws ClientException {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
return new CallRequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newCall);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,14 @@ public IEntityType2CollectionPage get() throws ClientException {
public void post(final EntityType2 newEntityType2, final ICallback<EntityType2> callback) {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
new EntityType2RequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newEntityType2, callback);
}

public EntityType2 post(final EntityType2 newEntityType2) throws ClientException {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
return new EntityType2RequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newEntityType2);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@ public void post(final EntityType3 newEntityType3, final ICallback<EntityType3>
final String requestUrl = getBaseRequest().getRequestUrl().toString();
final ReferenceRequestBody body = new ReferenceRequestBody(getBaseRequest().getClient().getServiceRoot() + "/testTypes/" + newEntityType3.id);
new EntityType3WithReferenceRequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newEntityType3, body, callback);
}

public EntityType3 post(final EntityType3 newEntityType3) throws ClientException {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
final ReferenceRequestBody body = new ReferenceRequestBody(getBaseRequest().getClient().getServiceRoot() + "/testTypes/" + newEntityType3.id);
return new EntityType3WithReferenceRequestBuilder(requestUrl,getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newEntityType3, body);
}
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,14 @@ public IEntityType3CollectionPage get() throws ClientException {
public void post(final EntityType3 newEntityType3, final ICallback<EntityType3> callback) {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
new EntityType3RequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newEntityType3, callback);
}

public EntityType3 post(final EntityType3 newEntityType3) throws ClientException {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
return new EntityType3RequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newEntityType3);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,14 @@ public ITimeOffCollectionPage get() throws ClientException {
public void post(final TimeOff newTimeOff, final ICallback<TimeOff> callback) {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
new TimeOffRequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newTimeOff, callback);
}

public TimeOff post(final TimeOff newTimeOff) throws ClientException {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
return new TimeOffRequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newTimeOff);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,14 @@ public ITimeOffRequestCollectionPage get() throws ClientException {
public void post(final TimeOffRequest newTimeOffRequest, final ICallback<TimeOffRequest> callback) {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
new TimeOffRequestRequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newTimeOffRequest, callback);
}

public TimeOffRequest post(final TimeOffRequest newTimeOffRequest) throws ClientException {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
return new TimeOffRequestRequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newTimeOffRequest);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,14 @@ public ICallRecordCollectionPage get() throws ClientException {
public void post(final CallRecord newCallRecord, final ICallback<CallRecord> callback) {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
new CallRecordRequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newCallRecord, callback);
}

public CallRecord post(final CallRecord newCallRecord) throws ClientException {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
return new CallRecordRequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newCallRecord);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,14 @@ public ISegmentCollectionPage get() throws ClientException {
public void post(final Segment newSegment, final ICallback<Segment> callback) {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
new SegmentRequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newSegment, callback);
}

public Segment post(final Segment newSegment) throws ClientException {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
return new SegmentRequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newSegment);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,14 @@ public ISessionCollectionPage get() throws ClientException {
public void post(final Session newSession, final ICallback<Session> callback) {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
new SessionRequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newSession, callback);
}

public Session post(final Session newSession) throws ClientException {
final String requestUrl = getBaseRequest().getRequestUrl().toString();
return new SessionRequestBuilder(requestUrl, getBaseRequest().getClient(), /* Options */ null)
.buildRequest(getBaseRequest().getOptions())
.buildRequest(getBaseRequest().getHeaders())
.post(newSession);
}

Expand Down