Skip to content

java selective imports + a bunch of bugfixes + namespace fixes #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Aug 28, 2020
Merged

java selective imports + a bunch of bugfixes + namespace fixes #278

merged 33 commits into from
Aug 28, 2020

Conversation

baywet
Copy link
Member

@baywet baywet commented Aug 26, 2020 •
edited
Loading

  • fixes interfaces and types names for stream properties that should have included property name to avoid conflicts (breaking)
  • adds selective imports to reduce build time and make building beta possible
  • fixes Edm.Decimal which was not mapped at all
  • fixes a bug where enums could have duplicate values
  • fixes a bug where navigation properties would be missing
  • fixes a bug where conflicting overfloads would be generated
  • fixes a bug where BaseClient would do invalid and unecessary casting
  • fixes an issues where entities ending in "Request" (search) would wreck the whole generation process
  • fixes an issue where request and builders would generate duplicate methods
  • fixes an issue where the documented type would be wrong
  • moves utility import generation method into page class
  • fixes an issue where interfaces would generate too many imports
  • adds a method to get imports for method parameters
  • adds casting of ctor parameters in call to disambiguous
  • multiple fixes to namespace and types generation methods
  • refactors type prefixing method for clarity
  • removes star imports

I still need to do a few things (hence the draft status)

  • merge OdcmMethodReturnNamespaceSection into GetPackagePrefix
  • refactor CreatePackageDef OdcmClass case
  • remove last .*; from templates (2 left)

baywet added 18 commits August 21, 2020 12:27
@baywet
- fixes interface names that should contain property name
ed901f9
@baywet
- update the models to reduce the import surface in generated classes
6364e11
@baywet
- adds missing processors so references stream interfaces are generat…
d07281f 
…ed and corresponding classes as well
@baywet
- fixes a bug where Edm.Decimal would not be mapped properly in Java
ad0cf48
@baywet
- fixes a bug where java enums could have duplicated values
efacbea
@baywet
- adds a distinct overloads methods to avoid generating similar overl…
26e07b0 
…oads in Java
@baywet
- adds the ability to get navigation properties from parent to avoid …
0b005bc 
…missing props
@baywet
- fixes an issue where a lot of generated java code would be missing …
8dfd3b2 
…imports
@baywet
- missing file
812c87b
@baywet
- fixes an issue where the client would do invalid casts
7abb4d4
@baywet
- fixes an issue where naviagation properties would be missing
fea4af3 
- fixes an issue where entities ending in request could wreck the code-gen process
@baywet
- fixes an issues where imports would be missing
03b2f74 
_ fixes an issue where the base client would do invlid casting
@baywet
- fixes an issue where request and builders would generate duplicate …
b89733d 
…methods
@baywet
- adds missing imports
4249fc1 
- fixes an issue where the documented type would be wrong
@baywet
- moves utility import generation method into page class
2297f95 
- fixes an issue where interfaces would generate too many imports
- adds a method to get imports for method parameters
- adds casting of ctor parameters in call to disambiguous
- multiple fixes to namespace and types generation methods
- refactors type prefxising method for clarity
- removes star imports
@baywet
- adds missing imports in javastream requests
f6c493f
@baywet
- merges changes from namespace support
ec1d627
@baywet
- minor fix for baseservice client implementation
67ba665
@baywet
- removes duplicate imports
f38e1c8 
- removes unused methods
- refactors imports inclusion
@baywet baywet marked this pull request as ready for review August 27, 2020 14:36
zengin
zengin suggested changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@zengin zengin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • minor perf: generation of com.microsoft.graph string in templates
  • style: single-line blocks with curly brackets
  • style: multi-line linq queries (for long ones)

zengin
zengin reviewed Aug 28, 2020
View reviewed changes
zengin
zengin previously approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@zengin zengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fixed a line I broke with my suggestion on switch statement "" -> "models.generated".

🚢 LGTM

@baywet baywet requested a review from zengin August 28, 2020 11:46
@baywet baywet self-assigned this Aug 28, 2020
@baywet
- fixes java generation test as the endpoint contains the version and…
824cfc5 
… the default options are not applied in this testing mode
@baywet baywet merged commit b9d490f into dev Aug 28, 2020
@baywet baywet deleted the bugfix/java-stream-properties branch August 28, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zengin zengin zengin approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

Assignees

@baywet baywet

Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baywet @zengin