Skip to content

add driver start callback API #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

mtfriesen
Copy link
Contributor

Description

Describe the purpose of and changes within this Pull Request.

Add a driver start callback API. This callback will be invoked each time the XDP driver has been started.

Testing

Do any existing tests cover this change? Are new tests needed?

CI for callback producer.

Documentation

Is there any documentation impact for this change?

This API will remain undocumented.

Installation

Is there any installer impact for this change?

No.

@mtfriesen mtfriesen added feature request New feature or request APIs API design and implementation labels Nov 12, 2024
@mtfriesen mtfriesen requested a review from a team as a code owner November 12, 2024 17:32
@mtfriesen mtfriesen merged commit 2886c03 into main Nov 13, 2024
52 checks passed
@mtfriesen mtfriesen deleted the mtfriesen/add_driver_start_callback branch November 13, 2024 21:47
@nibanks
Copy link
Member

nibanks commented Nov 14, 2024

What's the plan for unload/stop?

@mtfriesen
Copy link
Contributor Author

What's the plan for unload/stop?

The current strategy is the same as user mode, because they share the IO manager: anything dependent on XDP must be stopped before XDP will stop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIs API design and implementation feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants