Skip to content

Board Permissions #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 8, 2024
Merged

Board Permissions #650

merged 12 commits into from
Feb 8, 2024

Conversation

JStuve
Copy link
Collaborator

@JStuve JStuve commented Feb 2, 2024

Pull Request

Relevant Issue(s): Closes #635 , closes #309 , closes #474, closes #498, closes #342, closes #145, closes #49, closes #5

Description

Boards can now restrict access to teams or individuals during the creating, copying, or editing phase. A new tab view in the board modal will now have the existing "General", alongside a new "Permissions" tab to help manage access.

Bug or Feature?

  • Bug fix
  • New feature

Fundamentals

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated any relevant documentation accordingly.
  • I have included an update blurb (50 words or less) at the top of CHANGELOG.md,
    to be included with the next release.
    • I have included a link to this PR in that blurb.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Accessibility

  • I have tested my changes on both light and dark themes.
  • I have tested my changes on both mobile and desktop views, when needed.
  • I have included image descriptions and aria-labels where I can.

Screenshots and Logs

image

@JStuve JStuve requested a review from polatengin February 2, 2024 05:13
@JStuve JStuve assigned JStuve and unassigned JStuve Feb 2, 2024
@JStuve JStuve marked this pull request as ready for review February 2, 2024 05:18
@JStuve
Copy link
Collaborator Author

JStuve commented Feb 2, 2024

@polatengin Any thoughts on the CI - Frontend pipeline failing? I'm not aware of a test report that I'm suppose to upload.

Copy link
Member

@mindlessroman mindlessroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a first pass look here and will check out and run the code soon. LOVE IT SO FAR! Thank you @JStuve !!!!!

@mindlessroman
Copy link
Member

@polatengin Any thoughts on the CI - Frontend pipeline failing? I'm not aware of a test report that I'm suppose to upload.

I'll see if I can look into the failure here

@mindlessroman
Copy link
Member

@polatengin Any thoughts on the CI - Frontend pipeline failing? I'm not aware of a test report that I'm suppose to upload.

@JStuve @polatengin , I think it would be fixed by this recommendation on the action documentation. I'll see if I can make a PR soon to fix that.

@polatengin
Copy link
Collaborator

@polatengin Any thoughts on the CI - Frontend pipeline failing? I'm not aware of a test report that I'm suppose to upload.

@JStuve @polatengin , I think it would be fixed by this recommendation on the action documentation. I'll see if I can make a PR soon to fix that.

It was working until last week, @mindlessroman thanks for stepping up taking care of it 👍

@polatengin
Copy link
Collaborator

hey @JStuve , I see @mindlessroman creeated a PR to fix the CI pipeline issue. I approved and merged it 👍

Can I kindly ask you to sync with main branch in your branch, so the CI_FrontEnd issue will be resolved on your PR, and I can merge it 👍

Copy link
Collaborator

@polatengin polatengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@polatengin polatengin merged commit 8a2ef8b into main Feb 8, 2024
@polatengin polatengin deleted the 635-board-permissions branch February 8, 2024 19:02
@AndreK5
Copy link

AndreK5 commented Feb 9, 2024

When will this be available?

image

@JStuve JStuve mentioned this pull request Feb 10, 2024
12 tasks
@manjukn042
Copy link

Hi, Is this working for a group ? also no option to search an user as well.

Copy link

@youssef4675 youssef4675 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants