editor groups - resolve #96725 #96820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
added
the
candidate
deepak1556
approved these changes
May 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #96725
Editor groups use the editor input factories to serialize on shutdown and deserialize on startup. However, an editor factory is free to return
undefinedfor both cases to signal the editor cannot be restored.Upon serialization we alread make sure that
undefinedis handled properly, but not on startup when we deserialize for the list of MRU editors. We need to remove falsify values from the MRU array to ensure we are not storing undefined values in that set. Test added as well.