Add casts to silence breaks due to updated DOM types #248346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
approved these changes
May 14, 2025
lramos15
approved these changes
May 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses build errors with TS5.9 and the updated DOM types from microsoft/TypeScript#61647.
This fixes are currently handled via casts so as to avoid any runtime changes or significant changes to the types. In some cases, the casts address deficiencies in the types from external packages.
Some of the breaks could be fixed by modifying
VSBufferto only acceptBuffer<ArrayBuffer>, but this required significantly more casts in other locations. I leave it up to the discretion of the VSCode team as to whether more extensive changes are necessary.