Skip to content

Make indentation of API reference samples consistent #17358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2016

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Dec 15, 2016

Fixes #17356


I ensured <indent><space>*<space> was consistently in front of all the code blocks.

@Tyriar Tyriar added this to the January 2017 milestone Dec 15, 2016
@Tyriar Tyriar requested a review from jrieken December 15, 2016 23:48
@@ -1123,15 +1123,16 @@ declare module 'vscode' {
/**
* Derive a new Uri from this Uri.
*
* ```ts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this out of a @sample tag as it looked really bad on the website https://code.visualstudio.com/docs/extensionAPI/vscode-api#Uri.with

* "command": "extension.sayHello",
* "title": "Hello World"
* }]
* }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seemed to be missing a closing curly brace

@jrieken
Copy link
Member

jrieken commented Dec 20, 2016

LGTM

@jrieken jrieken merged commit 817beaf into master Dec 20, 2016
@jrieken jrieken deleted the tyriar/17356_api_indent branch December 20, 2016 08:43
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all code references in vscode.d.ts use consistent indentation
3 participants