show set display language action for lang pack extensions #154925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
approved these changes
Jul 13, 2022
Comment on lines
+268
to
+276
| if (!this.extension) { | ||
| return; | ||
| } | ||
| if (this.extension.isBuiltin) { | ||
| return; | ||
| } | ||
| if (this.extensionsWorkbenchService.canSetLanguage(this.extension)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
nit: maybe combine these if's?
There was a problem hiding this comment.
I would like to have separate checks for each condition for readability (I think its personal :) )
Comment on lines
+1256
to
+1262
| if (!isWeb) { | ||
| return false; | ||
| } | ||
|
|
||
| if (!extension.gallery) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
nit: is 2 ifs really more readable than 1?
|
@sandy081 does this change work alright for the pseudo language pack? |
|
Is that a special language pack? May I know how to try it? |
Yoyokrazy
pushed a commit
to Yoyokrazy/vscode
that referenced
this pull request
Jul 13, 2022
…s-set-display-lang show set display language action for lang pack extensions
andreamah
pushed a commit
that referenced
this pull request
Jul 14, 2022
…play-lang show set display language action for lang pack extensions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show set display language action for lang pack extensions
Fixes #154461