Skip to content

Improve command navigation behavior #145252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Improve command navigation behavior #145252

merged 2 commits into from
Mar 16, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 16, 2022

Fixes #145241

Summary:

  • All scroll/select now use 1/4 down the viewport instead of some top some middle
  • Scrolling no longer happens if the target line is within the viewport

Combined with #145245, looks like:

Recording 2022-03-16 at 11 27 56

@Tyriar Tyriar added this to the March 2022 milestone Mar 16, 2022
@Tyriar Tyriar requested a review from meganrogge March 16, 2022 18:31
@Tyriar Tyriar self-assigned this Mar 16, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Mar 16, 2022

I wonder if we should set the width of the outline based on the command text instead of spanning the full width?

This was my original plan but I think the main thing that would do is draw less attention to it

Also what does this look like if you have a multi line command?

Not that great 🙂, an improvement we could do later. Getting exact bounds of the command isn't super reliable right now, especially on Windows as well.

@Tyriar Tyriar merged commit e8980d8 into main Mar 16, 2022
@Tyriar Tyriar deleted the tyriar/145241 branch March 16, 2022 18:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve command tracking scroll behavior
2 participants