Skip to content

Create sync test suite that verifies the right headers are being sent in various situations #90076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tyriar opened this issue Feb 5, 2020 · 1 comment
Assignees
Labels
debt Code quality issues settings-sync
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 5, 2020

I suggest creating unit tests that swap out the request service in order to simulate the server. This is very important as shipping a version where the requests are broken has the potential to DDoS the server which will cause problems that we can't really fix without waiting it out for clients to update, and there will always be a long tail of clients that don't get updated. Some cases we need to test:

Consider starting on the framework for this as a minimum in Feb, we need a comprehensive test suite by the time we're out of preview.

@Tyriar Tyriar added this to the February 2020 milestone Feb 5, 2020
@sandy081 sandy081 added the debt Code quality issues label Feb 5, 2020
@sandy081 sandy081 mentioned this issue Feb 6, 2020
6 tasks
sandy081 added a commit that referenced this issue Feb 18, 2020
sandy081 added a commit that referenced this issue Feb 18, 2020
- Adopt to new v1 URLs
- Add end to ened sync tests
sandy081 added a commit that referenced this issue Feb 18, 2020
@sandy081
Copy link
Member

Added tests to cover all sync scenarios.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues settings-sync
Projects
None yet
Development

No branches or pull requests

2 participants