Skip to content

Finalize Webview persistence API #49022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mjbvz opened this issue May 1, 2018 · 3 comments
Closed

Finalize Webview persistence API #49022

mjbvz opened this issue May 1, 2018 · 3 comments
Assignees
@mjbvz
Labels
api-proposal on-testplan webview Webview issues
Milestone
June 2018

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented May 1, 2018

Finalize the proposed webview serialization API: https://github.com/Microsoft/vscode/blob/245155d1614ce3cec37738c984369b8b03c4c32f/src/vs/vscode.proposed.d.ts#L291

Open questions:
@mjbvz mjbvz added webview Webview issues api-proposal labels May 1, 2018
@mjbvz mjbvz added this to the May 2018 milestone May 1, 2018
@mjbvz mjbvz self-assigned this May 1, 2018
@mjbvz mjbvz mentioned this issue May 1, 2018
Closed
@mjbvz
Copy link
Collaborator Author

mjbvz commented May 14, 2018 •
edited
Loading

Proposed changes:

  • Remove serialize. Always use the state from setState inside the webview. This avoids having to call out to extensions on shutdown.
  • Pass the state from setState to deserialize

One downside is that webviews have to have js enabled for this to work

mjbvz added a commit that referenced this issue May 14, 2018
@mjbvz
Working on webview persistence API
21ee81c 
#49022
@kieferrm kieferrm mentioned this issue May 16, 2018
Closed
46 tasks
@mjbvz mjbvz closed this as completed May 23, 2018
@mjbvz mjbvz mentioned this issue May 29, 2018
Closed
2 tasks
@mjbvz mjbvz modified the milestones: May 2018, June 2018 May 31, 2018
@mjbvz mjbvz reopened this May 31, 2018
@mjbvz
Copy link
Collaborator Author

mjbvz commented May 31, 2018

Moving back to proposed for a little more polishing

mjbvz added a commit that referenced this issue May 31, 2018
@mjbvz
Moving webview api back to proposed for more polishing
df7f125 
#49022
@kieferrm kieferrm mentioned this issue Jun 8, 2018
Closed
52 tasks
@mjbvz mjbvz removed the on-testplan label Jun 14, 2018
@jdgarcia jdgarcia mentioned this issue Jun 19, 2018
Closed
@mjbvz mjbvz mentioned this issue Jun 25, 2018
Closed
2 tasks
@mjbvz
Copy link
Collaborator Author

mjbvz commented Jun 27, 2018

Fixed by 2ed5aee

@mjbvz mjbvz closed this as completed Jun 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api-proposal on-testplan webview Webview issues
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
1 participant
@mjbvz