Skip to content

Create and remove manual folding range use the same shortcut #156489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aeschli opened this issue Jul 27, 2022 · 4 comments · Fixed by #156490
Closed

Create and remove manual folding range use the same shortcut #156489

aeschli opened this issue Jul 27, 2022 · 4 comments · Fixed by #156490
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues verification-found Issue verification failed verified Verification succeeded
Milestone
August 2022

Comments

@aeschli
Copy link
Contributor

aeschli commented Jul 27, 2022

image

Originally posted by @tjx666 in #155302 (comment)
@aeschli aeschli added this to the July 2022 milestone Jul 27, 2022
@aeschli aeschli self-assigned this Jul 27, 2022
@aeschli aeschli added editor-folding Editor code folding issues bug Issue identified by VS Code Team member as probable bug labels Jul 27, 2022
aeschli added a commit that referenced this issue Jul 27, 2022
@aeschli
Create and remove manual folding range use the same shortcut. Fixes #…
e4dfb84 
…156489
@aeschli aeschli mentioned this issue Jul 27, 2022
Merged
aeschli added a commit that referenced this issue Jul 27, 2022
@aeschli
Create and remove manual folding range use the same shortcut. (#156490)
59afa0a 
Create and remove manual folding range use the same shortcut. Fixes #156489
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 27, 2022
@connor4312 connor4312 added the verified Verification succeeded label Jul 28, 2022
@connor4312
Copy link
Member

This doesn't work for me: as soon as I assign the same keybinding to both add and remove the folding range, then creating the folding range no longer works. I can create the folding range from the command palette and then remove it using the keybinding, but cannot create it.

@connor4312 connor4312 reopened this Jul 28, 2022
@connor4312 connor4312 added verification-found Issue verification failed and removed verified Verification succeeded labels Jul 28, 2022
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Jul 28, 2022
@alexdima alexdima self-assigned this Jul 29, 2022
@alexdima
Copy link
Member

I think the bug was that the two commands are using the same shortcut, and the fix was to assign a different shortcut to one of the commands. Leaving this up to Martin to clarify during August, but I don't think there is anything to be done for July.

@alexdima alexdima removed their assignment Jul 29, 2022
@alexdima alexdima modified the milestones: July 2022, August 2022 Jul 29, 2022
@connor4312
Copy link
Member

It'd be handy if one command worked for both so I could toggle the folded region.

@aeschli
Copy link
Contributor Author

aeschli commented Aug 22, 2022

That would be a separate feature request. Closing this issue (fixing the conflict) as fixed.

@aeschli aeschli closed this as completed Aug 22, 2022
@aiday-mar aiday-mar added the verified Verification succeeded label Aug 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

Create and remove manual folding range use the same shortcut. microsoft/vscode
5 participants
@connor4312 @alexdima @aeschli @aiday-mar @vscodenpa