Skip to content

Notebook web integration tests are commented out #126384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpasero opened this issue Jun 15, 2021 · 2 comments
Closed

Notebook web integration tests are commented out #126384

bpasero opened this issue Jun 15, 2021 · 2 comments
Assignees
@roblourens
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook web Issues related to running VSCode in the web
Milestone
June 2021

Comments

@bpasero
Copy link
Member

bpasero commented Jun 15, 2021 •
edited
Loading

And I have not seen an opened issue for this, so we should either make them reliable or delete them:

  • test-web-integration.sh
  • test-web-integration.bat
@bpasero bpasero added notebook web Issues related to running VSCode in the web labels Jun 15, 2021
@bpasero bpasero mentioned this issue Jun 15, 2021
Open
@roblourens roblourens assigned roblourens and unassigned rebornix Jun 17, 2021
@roblourens
Copy link
Member

Notebook integration tests now live in vscode-api-tests, and vscode-notebook-tests only contains an extension for the smoke test, so it can be removed from all the integration test scripts

@roblourens roblourens added the debt Code quality issues label Jun 17, 2021
@roblourens roblourens added this to the June 2021 milestone Jun 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2021
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@roblourens
Remove unneeded vscode-notebook-tests references
f5df815 
Fix microsoft#126384
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook web Issues related to running VSCode in the web
Projects
None yet
Milestone
June 2021
Development

No branches or pull requests
4 participants
@roblourens @rebornix @bpasero and others