Use resolveAsync in terminal Variable Resolver #120328
Labels
debt
Code quality issues
important
Issue identified as high-priority
insiders-released
Patch has been released in VS Code Insiders
perf-startup
terminal
General terminal issues that don't fall under another label
Milestone
With #108804 we are trying to remove process.env from the configuration resolver service. The new way to get the environment is async and requires that the all the configuration resolver methods be async. I have started the adoption of the new async methods in #120326, but there's one use in terminal that looks like it will require more work:
vscode/src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts
Lines 266 to 271 in 02d3809
Option 1: Convert that use of
resolve
to useresolveAsync
.Option 2: I provide a new
resolveWithEnv
method on the configuration resolver service that is sync, but requires you to pass in your ownIProcessEnvironment
.Which option makes the most sense here?
The text was updated successfully, but these errors were encountered: