Use resolveAsync in terminal Variable Resolver

[alexr00]

With #108804 we are trying to remove process.env from the configuration resolver service. The new way to get the environment is async and requires that the all the configuration resolver methods be async. I have started the adoption of the new async methods in #120326, but there's one use in terminal that looks like it will require more work:

vscode/src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts

Lines 266 to 271 in 02d3809

	export function createVariableResolver(lastActiveWorkspace: IWorkspaceFolder | undefined, configurationResolverService: IConfigurationResolverService | undefined): VariableResolver | undefined {
	if (!configurationResolverService) {
	return undefined;
	}
	return (str) => configurationResolverService.resolve(lastActiveWorkspace, str);
	}

Option 1: Convert that use of resolve to use resolveAsync.
Option 2: I provide a new resolveWithEnv method on the configuration resolver service that is sync, but requires you to pass in your own IProcessEnvironment.

Which option makes the most sense here?

[Tyriar]

I think the usage of VariableResolver in extHostTerminalService must remain sync since it's used as part of the extension API. Is this a problem there since process.env is fine to use? The main purpose of this VariableResolve type was to share code between variable processes.

[alexr00]

Sounds like Option 2 is the way to go then. I will add a new resolveWithEnv method that is sync and lets you pass in your own IProcessEnvironment.

[alexr00]

Added:

vscode/src/vs/workbench/services/configurationResolver/common/configurationResolver.ts

Lines 37 to 38 in d06df60

	resolveWithEnvironment(environment: IProcessEnvironment, folder: IWorkspaceFolder | undefined, value: string): string;

will that let you keep your code reuse?