Skip to content

Add tests for notebook cell manipulations #12204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2020
Merged

Add tests for notebook cell manipulations #12204

merged 1 commit into from
Jun 9, 2020

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Jun 8, 2020 •
edited
Loading

For #10496

  • Added tests, to ensure changes to API will not break our code (the API used to handle/detect cell manipulations have changed a couple of times)
  • Might have to add more tests (if the API changes and breaks our tests, I'll add more tests - only if API changes, which I believe will)

@DonJayamanne DonJayamanne changed the title Add tests for cell manipulations Add tests for notebook cell manipulations Jun 8, 2020
DonJayamanne
DonJayamanne commented Jun 8, 2020
View reviewed changes
src/test/datascience/notebook/edit.ds.test.ts

await handler.assertFiredExactly(1); // Delete last cell.
// Bug in VS Code.
assertCodeCell(0, 'PYTHON1PYTHON2');
Copy link
Author

@DonJayamanne DonJayamanne Jun 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a known upstream but

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Jun 8, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@DonJayamanne DonJayamanne merged commit 0000b95 into microsoft:master Jun 9, 2020
@DonJayamanne DonJayamanne deleted the addCellManipTests branch June 9, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

@greazer greazer Awaiting requested review from greazer

@joyceerhl joyceerhl Awaiting requested review from joyceerhl

@techwithtim techwithtim Awaiting requested review from techwithtim

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DonJayamanne @IanMatthewHuff @rchiodo