Updates to cell status displayed in VS Code Notebooks #12126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Jun 3, 2020
| @@ -138,3 +139,34 @@ export function updateCellOutput(notebookCellModel: ICell, outputs: nbformat.IOu | |||
| }; | |||
| model.update(updateCell); | |||
| } | |||
|
|
|||
| export function updateCellMetadata( | |||
There was a problem hiding this comment.
Added cuz we need this.
Not used as we will need to discuss the implications etc.. (will book meeting to discuss this)
DonJayamanne
commented
Jun 3, 2020
| import { JSONObject } from '@phosphor/coreutils'; | ||
|
|
||
| // This is the custom type we are adding into nbformat.IBaseCellMetadata | ||
| export interface IBaseCellVSCodeMetadata { |
There was a problem hiding this comment.
Overriding to add custom metadata with strong typing.
This IBaseCellVSCodeMetadata is the only new change along with a property, rest has been copied from jupyter.
DonJayamanne
commented
Jun 3, 2020
| /** | ||
| * VS Code cell metadata. | ||
| */ | ||
| vscode: Partial<IBaseCellVSCodeMetadata>; |
There was a problem hiding this comment.
Here's the new optional property we're adding with strong typing.
DonJayamanne
commented
Jun 3, 2020
| /** | ||
| * VS Code cell metadata. | ||
| */ | ||
| vscode?: Partial<IBaseCellVSCodeMetadata>; |
There was a problem hiding this comment.
Our custom metadata to be stored in jupyter cell.
DonJayamanne
requested review from
DavidKutu,
greazer,
IanMatthewHuff,
joyceerhl,
rchiodo and
techwithtim
IanMatthewHuff
approved these changes
Jun 3, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10496