Cancelling should invoke a single interrupt #12106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
requested review from
rchiodo,
DavidKutu,
greazer,
IanMatthewHuff,
joyceerhl and
techwithtim
| this.commandManager.executeCommand(Commands.NotebookEditorInterruptKernel).then(noop, noop); | ||
| } | ||
| }); | ||
|
|
||
| cell.metadata.runStartTime = new Date().getTime(); | ||
| cell.metadata.runState = vscodeNotebookEnums.NotebookCellRunState.Running; | ||
|
|
||
| if (!findMappedNotebookCellModel(cell, model.cells)) { |
There was a problem hiding this comment.
Yes, we don't need it anymore. Was there due to missing VSC API.
IanMatthewHuff
approved these changes
Jun 2, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
rchiodo
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10496
Runing entire notebook and clicking cancel would result in kernel being interrupted n times (where n = number of cells).
I.e. user clicks cancel once, but we end up interrupting multiple times.